search

littleuniversestudios / angular-cli-tools

Command Line Tools for Angular 2 projects
MIT License
30 stars 8 forks source link

make directory configurable #19

Open stweedie opened 6 years ago

stweedie commented 6 years ago

I'm proposing a change to use a .angular-cli-tools.json file at the root level of the project instead of looking for a config file in a hardcoded directory. From the config, we are already allowed to set custom paths to templates and such, but we still need a angular-cli-tools folder at root. Maybe it should be called .angular-cli-tools.json to mirror angular-cli's config.

I can also create a PR if you agree with this proposal.

nvitas commented 6 years ago

I like the idea @stweedie.

Let me think about the logistics of this move.

I just need to wrap my head around storing the .angular-cli-tools.json file at the root and essentially in the project repo (or should it be ignored by git??). That config file could point to some custom saved templates that only one person has stored locally but now, because the config file is shared, other members would see the custom saved templates. However, they wouldn't have those templates because the angular-cli-tools folder isn't in the repo (at least the way we use it it's not)

Just need to think about this a little more but I like the idea.

What's the main benefit of having the .angular-cli-tools.json at the root?