littlewater / gst123

Automatically exported from code.google.com/p/gst123
0 stars 0 forks source link

Local files not properly escaped when converted to URLs #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

`gst123 file%20with%20percent-encoded%20chars.wav`

What is the expected output? What do you see instead?

I expect "file%20with%20percent-encoded%20chars.wav" to play, but gst123 will 
try to play "file with percent-encoded chars.wav".  When not passing local file 
names (i.e., *not* URLs) special characters should be escaped.

What version of the product are you using? On what operating system?

Tested with 0.2.1 and git master

Please provide any additional information below.

Patch attached.  I'm not sure what the desired behavior is for playlists so I 
left that part of the code alone, but it may be possible to get rid of 
Player::add_uri_or_directory completely.

Original issue reported on code.google.com by nem...@gmail.com on 10 Jun 2012 at 9:55

Attachments:

GoogleCodeExporter commented 9 years ago
Same issue for file names with a # in them.

Original comment by nem...@gmail.com on 30 Nov 2012 at 11:39

GoogleCodeExporter commented 9 years ago
I've not applied your patch, but a rewritten version; so the issue should be 
fixed in the next version (gst123 0.3.3).

Original comment by Stefan.W...@gmail.com on 3 Jun 2013 at 10:29