search

littleweeb / Desktop

Codebase for all the desktop versions (mac, linux & windows).
https://littleweeb.github.io
MIT License
132 stars 14 forks source link

Default directory for storing settings/log files (Prev. Crashes under osx). #1

Open HelmoHass opened 5 years ago

HelmoHass commented 5 years ago

Tried your app under 10.12.6 and seem working fine at first. * As per OSX native behaviour I'll suggest (into preferences) giving the possibility to copy/paste directories and other modification paths needed. As it is now ofc works but not really intuitive. Also (but this really depends on the actual feeds urls you choose) as for what i can see many shows are missing (my guess is, the ones involved are those in between seasons they are not displayed )
Anyway good work, but needs some fixes and polishing.

here' the log https://pastebin.com/UdwrdjUh

EldinZenderink commented 5 years ago

Hi, would you be willing to join the Discord to help debugging these issues? Unfortunately I am not really experienced with OSX, and the log that you provided wasn't really helpfull (well I can't figure out exactly what exactly is going on with that log). LittleWeeb itself generates log files as well, here is a video that should help locate them: https://www.youtube.com/watch?time_continue=49&v=hxcVy56M1Po

Did you download the release version directly from the site or a develop version from the github releases page?

I am waiting for another dude that is unfortunately quit impossible to reach lately to test the develop version as I (probably) have fixed an issue that made it crash after the first launch as well. Technically what happend is that electron starts a separate process running the back-end but never closes it when you close littleweeb. When relaunching it throws an error due to the process still running and crashes. If thats the same issue, it should be fixed within the develop version.

Edit*: regarding not all airing anime showing up: unfortunately I am bound by horriblesubs releases for checking which one aired the latest. I probably should add a section with releases that arent done by horrible, but that won't always update as they are probably hosted on bots that sometimes release older animes as well (messing up the currently airing page). In the future I am going to do some addition processing to get the non horriblesubs releases listed as well, but that will come later (as I am moving more logic from the front to the back-end (front-end is currently parsing the api's to combine the information from https://nibl.co.uk and kitsu)).

HelmoHass commented 5 years ago

Hi, no problems i can eventually go there I'm using the site version. But what i've found is not electron related issue. watching activities log, found out that is the main executable itself being the cause, which exactly as you described, doesn't quit after closing the application and result is what we experienced. I guess the solution is there .

EldinZenderink commented 5 years ago

Ah yes, the cause of that is that when a child process causes an error and you dont catch it, it crashes the main process as well(and thats what is happening with the non develop release version, I fixed that with the develop version, but I need it tested by someone with an actual mac (due to hw acceleration issues in my vm) to be sure, so I feel like I shouldn't release it yet, but I will eventually if noone is available to test it, with the risk of other issues arising. Thanks anyway for your help!

EldinZenderink commented 5 years ago

I am going to presume that the issue has been resolved. In case that is not true, we shall reopen it.

HelmoHass commented 5 years ago

Hi sorry, for late response I tested the developers version, and seem to work flawlessly, as you stated, this release fixed that behaviour causing the main process to crash.

i would suggest to replace the download links in your homepage,

Also, not a big deal, but (for future releases,if any) you should consider modifying is the path to its settings folder, on osx normally any application store its own files into $HOME/Library/Application\ Support/

EldinZenderink commented 5 years ago

Thanks for confirming! The developer version can now be found on the websites as well, but since you stated that it works more or less flawlessly I will make it a release version asap. I didn't know about the default director for storing this stuff. Will look into it.