litzvi / avc-beta

trying to build first demo for avc
0 stars 0 forks source link

select blur and submit race #546

Closed litzvi closed 3 years ago

litzvi commented 3 years ago
  1. POS - not showing value in 'Product company' column

  2. Cashew Schedules - what are the 2 lines in the summary table on the bottom. They have the same data, and doesn't say in the beginning of the row what it is. is it a total? If it's by supplier, it's not showing correctly.
  3. When I remove cashew grade from an item (in edit) you are trting to send an empty String instead off null, causing an error.
  4. By what are you filtering QC item dropdown? e.g. 50lb-sk-toffee (production use = packed) is showing (other roast aren't showing)
  5. Raw relocation and cleaning not showing anything in item dropdown (I'm using W340) - after I set the grades.
mei309 commented 3 years ago

1) because poBasic dosent have the filed (i think it had before) or make a new function with it. 2) on the second line it says total. if not send me a screenshot and f12 (by me it writes) its by type and person in charge and since they wanted it that way but they dont use it it looks strange. (i think we should leave it this way). 3) by me this is working but changing isnt working. and im doing the same as everywhere so it sounds strange. 4) it doesn't look the case by me but anyway im using your function if(roast) { return refeDao.getItems(ItemGroup.PRODUCT, new ProductionUse[]{ProductionUse.CLEAN, ProductionUse.ROAST}, PackageType.BULK); } else { return refeDao.getItems(ItemGroup.PRODUCT, new ProductionUse[]{ProductionUse.ROAST, ProductionUse.RAW_KERNEL}, PackageType.BULK); }

5) cannot check without the new version

litzvi commented 3 years ago

because poBasic dosent have the filed (i think it had before) or make a new function with it.

I added, now set it to display (productCompanyName).

litzvi commented 3 years ago

by me this is working but changing isnt working. and im doing the same as everywhere so it sounds strange.

When I delete the grade and leave it blank, seems like you are trying to set with a blank String "" (empty) instead of null. Other places it might be mandatory so it doesn't happen. Here's the error

com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of com.avc.mis.beta.entities.values.CashewGrade (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('') at [Source: (String)"{"id":12,"value":"W320","grade":"","saltLevel":"NS","measureUnit":"KG","productionUse":"RAW_KERNEL"}"; line: 1, column: 33] (through reference chain: com.avc.mis.beta.entities.item.CashewItem["grade"])

litzvi commented 3 years ago

cannot check without the new version

Sorry didn't realize. I'll upload a version now. please fix it asap and upload new so I can check.

mei309 commented 3 years ago
  1. fixed
mei309 commented 3 years ago

by me this is working but changing isnt working. and im doing the same as everywhere so it sounds strange.

When I delete the grade and leave it blank, seems like you are trying to set with a blank String "" (empty) instead of null. Other places it might be mandatory so it doesn't happen. Here's the error

com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of com.avc.mis.beta.entities.values.CashewGrade (although at least one Creator exists): no String-argument constructor/factory method to deserialize from String value ('') at [Source: (String)"{"id":12,"value":"W320","grade":"","saltLevel":"NS","measureUnit":"KG","productionUse":"RAW_KERNEL"}"; line: 1, column: 33] (through reference chain: com.avc.mis.beta.entities.item.CashewItem["grade"])

it doesn't seem to have problems by me

mei309 commented 3 years ago
  1. you changed the grade you give me therefor it happened (it didnt work anywhere) fixed
mei309 commented 3 years ago

please let me know about 2 and 4?

litzvi commented 3 years ago

please let me know about 2 and 4?

  1. i agree - just forgot
  2. It's a definition error they did in that item
mei309 commented 3 years ago

so all done

litzvi commented 3 years ago

When I remove cashew grade from an item (in edit) you are trting to send an empty String instead off null, causing an error.

NOT SOLVED. and it's the same everywhere

mei309 commented 3 years ago

i know im setting empty string but its working by me. (also now with your newest version) jackson dose consider "" as null in those cases. did you change something like to make it a strong conversation??

litzvi commented 3 years ago

I did nothing, its not working. Try just deleting an existing value and leaving it blank

On Wed, Jul 21, 2021, 11:39 mei309 @.***> wrote:

Assigned #546 https://github.com/litzvi/avc-beta/issues/546 to @litzvi https://github.com/litzvi.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/litzvi/avc-beta/issues/546#event-5047975193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMZHF3BLXZBDYRPXTEULHC3TYZFR3ANCNFSM5ARTT36A .

mei309 commented 3 years ago

I did nothing, its not working. Try just deleting an existing value and leaving it blank On Wed, Jul 21, 2021, 11:39 mei309 @.***> wrote: Assigned #546 <#546> to @litzvi https://github.com/litzvi. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#546 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMZHF3BLXZBDYRPXTEULHC3TYZFR3ANCNFSM5ARTT36A .

i did and it works by me. and its very strange that by me it works and by you not

mei309 commented 3 years ago

https://user-images.githubusercontent.com/58453503/126438498-b22e908d-5684-4ccc-8caf-f22ddc680691.mp4

litzvi commented 3 years ago

I see. it's happening by me because the dropdown is still open when I submit. So don't press outside before you submit. just submit directly after you delete the word while the dropdown is still hanging.

mei309 commented 3 years ago

its a big problem it will take time to fix it if i can

mei309 commented 3 years ago

fixed. it might have consequences so if you see problems with the dropdowns let me know. i checked a lot but meanwhile didnt find