confirm, save buttons in management

[litzvi]

A little bizarre bug we had this morning. I removed approval for Eli in receipts but left the Management. There are still lots from last week in pending - therefore they still require approval. But he couldn't finalize the lot because you removed the confirm button based on current requirements.

Managed to get around it for now.

They way I designed it, approval requirements aren't changed retroactively. Therefore shouldn't depend on management configuration but on given process. Perhaps it should be changed, so I need to change the design for flexible approval. Create approval/rejection when added.

[litzvi]

• com.avc.mis.beta.repositories.ProcessRepository.findGeneralProcessInfoByProcessId(int, Class<? extends T>) - FIX - no need, will show only decisions made
• com.avc.mis.beta.dao.ProcessInfoDAO.addAlerts(GeneralProcess) - REMOVE ADDING APPROVAL -done
• com.avc.mis.beta.dao.ProcessInfoDAO.editAlerts(GeneralProcess) - NO NEED IF BECAUSE THERE IS NO NOT ATTENDED -done
• create approvals not created on the fly for processes that are pending.

[litzvi]

The problem is adding an approval for a user will add approvals from beginning of time.

[litzvi]

Or maybe remove the connection between the approval and status.

[litzvi]

The problem is adding an approval for a user will add approvals from beginning of time.

only need to approve not finalized processes.

[litzvi]

• com.avc.mis.beta.dao.ProcessInfoDAO.setProcessStatus(ProcessStatus, Integer) - find needed approvals left join approvals

          if(getProcessRepository().waitingApprovals(processId).size() > 0) {
              throw new IllegalStateException("Can't finalize process before fully approved");
          }

  // List approvals = getProcessRepository().findProcessApprovals(processId); // if(approvals.stream().anyMatch(a -> a.getDecision() != DecisionType.APPROVED)) { // throw new IllegalStateException("Can't finalize process before fully approved"); // }

[litzvi]

• com.avc.mis.beta.dao.ProcessInfoDAO.setUserProcessDecision(int, DecisionType, String, String) - add approval if needed

old code:

Optional optional = getProcessRepository().findProcessApprovalByProcessAndUser(processId, getCurrentUserId()); //(change) if exists send to previous method, otherwise IF THE USER NEEDS APPROVAL, create one and add ApprovalTask approval = optional.orElseThrow(() -> new AccessControlException("No approval task for current user")); approval.setDecision(decision); approval.setProcessSnapshot(processSnapshot); approval.setRemarks(remarks); editEntity(approval); approvalAlerts(approval);

[litzvi]

@litzvi don't use com.avc.mis.beta.repositories.ProcessInfoRepository.findApprovals(Integer, DecisionType[], Instant, Instant). Change to a dedicated method to get the report.

[litzvi]

@litzvi don't use com.avc.mis.beta.repositories.ProcessInfoRepository.findApprovals(Integer, DecisionType[], Instant, Instant). Change to a dedicated method to get the report.

done