search

litzvi / avc-beta

trying to build first demo for avc
0 stars 0 forks source link

fixing process gain #607

Open litzvi opened 2 years ago

litzvi commented 2 years ago

can't display details and can't edit. I don't see anything by me.

i'll attach a dump

litzvi commented 2 years ago

Dump20211005_mei.zip

mei309 commented 2 years ago

fixed

mei309 commented 2 years ago

why processGain: null in a case like this po? theres no used item but theres a lot of produced items so it should be a big gain

litzvi commented 2 years ago

why processGain: null in a case like this po? theres no used item but theres a lot of produced items so it should be a big gain

yes. but in percentage it will be undefined or infinity. so I thought better to leave it empty

mei309 commented 2 years ago

process gain isnt for percentage

mei309 commented 2 years ago

and in percentage i should put infinite. empty they would not see something strange

litzvi commented 2 years ago

and in percentage i should put infinite. empty they would not see something strange

implement infinite might cause bags. I can do it after we upload. unless you show null as infinity. do you want that? I HAVE A SOLUTION. DEFINE IT IN com.avc.mis.beta.entities.embeddable.AmountWithUnit.percentageLoss(AmountWithUnit, AmountWithUnit) AND SET RETURN to AmountWithUnit and percentage/infinty.

litzvi commented 2 years ago

anyway, don't close because i need to fix it when we upload a version

litzvi commented 2 years ago

don't know what you are writing BigDecimal doesn't have infinity. also the logic isn't correct

mei309 commented 2 years ago

you need to fix the process gain so we see the difference in lbs. and all the rest. im doing the percantage alone