search

liuch / dmarc-srg

A php parser, viewer and summary report generator for incoming DMARC reports.
GNU General Public License v3.0
219 stars 32 forks source link

"Mark all read" feature #12

Open wcz-txp opened 2 years ago

wcz-txp commented 2 years ago

Hello,

first of all, thank you for this very useful tool. Installed version 1.2 yesterday on Debian Buster with PHP 8.0.13 and it worked out of the box.

Because I don't really want to open every report in the GUI, I would like to have a button, which is marking all these reports as read.

Thanks anyway!

liuch commented 2 years ago

Hello,

I'm glad that my tool is useful for you. By the way, I'm using Debian too.

What about the feature you offer: I don't really open every report. Honestly, I only open only messages that did not pass DKIM check after I saw this in the summary report (I just set the filter dkim=failed in GUI for that). I'm not paying attention to this flag, this is just additional information for me just in case. This flag does not affect anything. So, If possible, would you like to tell me why you need this button? Maybe there is another way to make the same. For example, it might be better to add an option to automatically set this flag to all reports when they are added to the database.

Thanks for your feedback!

wcz-txp commented 2 years ago

If I think about it one more time, than it is maybe not necessary, because in config.php one can define when to delete older reports. But on the other hand, I don't really know yet, how many reports I get in a week, but this can be dozens and actually I have defined to delete older reports after three months, so this can get a huge amount and marking reports all read, could be useful not to get lost, if I for example in this scenario of 90 days only two times look into these reports.

These reports came in since yesterday: dmarcreport

Would be nice to have, but it is not essential :-)

P.S. Yes, I know the filter button :smiley:

liuch commented 2 years ago

Thanks for the information. I’ll think about how to do it most carefully. BWT: My list of reports is much more modest. Usually it is no more than 5 reports a day.

williamdes commented 1 year ago

This was missing to me today, when I imported 3 years of reports. I used a SQL query to set read=1 on all items

liuch commented 1 year ago

To my shame, I must admit that my problem here is not in the code, but in the planning of the interface. I'm not good at this. I will try.

williamdes commented 1 year ago

To my shame, I must admit that my problem here is not in the code, but in the planning of the interface. I'm not good at this. I will try.

I love your simplistic and clean interface 💯

liuch commented 1 year ago

Thank you. It was born in pain!