search

liuch / dmarc-srg

A php parser, viewer and summary report generator for incoming DMARC reports.
GNU General Public License v3.0
213 stars 31 forks source link

Bug: Menu Broken #129

Closed andrewhenke closed 1 day ago

andrewhenke commented 2 months ago

I just pulled the most recent code from the repository and noticed that the "users" tab under "administration" does not show anymore, but when I go to example.com/users.php I can still manage and add users, etc. Just wanted to let you know so that it can be fixed.

andrewhenke commented 2 months ago

Update: I realized that I needed to move the user_management configuration item from the $admin variable where it was previously defined, to the $users variable, which I didn't have in my template version of the config file yet. Once I added this, it added the item back to the menu.

One thing that I noticed, however, is that when the user_management variable was still set in the $admin variable, I was able to access and edit/create users from the users.php page still, by navigating directly to the page

liuch commented 2 months ago

You are right. the user_management was moved. As for the menu being available when the user_management is disabled - I am aware of this behavior. I decided that special blocking of this page would be unnecessary. The users.php page is inaccessible to ordinary users anyway and authentication is forbidden for them. Maybe I should add terminating already active user sessions when the user_management is disabled. What do you think about that?