search

liuch / dmarc-srg

A php parser, viewer and summary report generator for incoming DMARC reports.
GNU General Public License v3.0
228 stars 34 forks source link

I made a DarkTheme #18

Closed kramwell closed 2 years ago

kramwell commented 2 years ago

Hey, great project this app has so much potential!

I have spent the last few days looking under the hood, some very complex stuff, I am by no means a PHP wizard so there is plenty I don't understand...

I created a DarkTheme anyway, mainly for my poor eyes as looking at this on a white screen at night can certainly sting.

Let me know what you think!

https://github.com/kramwell/dmarc-srg_darktheme

liuch commented 2 years ago

Hey kramwell, Of course, I think it is a good idea to add a dark theme to the project. But now I don't have time for that. Your theme is good, but in my opinion it's too black and the dialogues are too light. I would do this using CSS variables, detecting the browser's theme with the preferences-color-scheme CSS media query, and i would use JavaScript to toggle it in as an option. Thanks for your interest in my project!

kramwell commented 2 years ago

Hey Liuch,

I looked into that, but thought about if other people wanted to throw their theme into the mix it would be easier to set the chosen theme in the php config file and that in turn sets as session var, then picked up from js (or convert index.html to php) and it selects the correct theme. something like that anyway... I think this approach wont limit the choice to dark/light only and encourages creativity.

and I see my theme as more the classic black theme I guess.. now I have the colours in one CSS its much easier to change this now to create new ones such as a github themed (which is more like dark theme I guess). my screen brightness is always at 0 so ill check your opinion and play around with the whites and see if I can balance some more.

Thanks!

liuch commented 2 years ago

it would be easier to set the chosen theme in the php config file

Your suggestion would be great if there was a guarantee that only one person uses the web-interface, they like only one theme, and their browser theme is not automatically changed depending on the time of day. I think this option should not be related to a server but a browser.

liuch commented 2 years ago

If you want to do it your way, then I recommend putting this option not in the configuration file, but in the section Setting->Advanced

kramwell commented 2 years ago

that would work, then all the admin has to do is load a new css into the css directory (or theme dir), define the filename in settings-advanced (or it picks it up) and you could select the theme with a check box or something then stores a non expiring session var if you wanted to define on per user/per computer basis / or updates the DB for system wide.

liuch commented 2 years ago

You inspired me to a feat: I have just added a dark theme. So far, only automatic switching is available.

kramwell commented 2 years ago

That's awesome! it looks really nice and clean. I have made a few edits that I think are worthy of a look, and fixed the grey out issue with disabled text (maybe you can see a better way?)

Let me know what you think.

https://github.com/liuch/dmarc-srg/compare/master...kramwell:master

You might also notice I swapped the log display order to newest-oldest as reading oldest-to-newest is a pain to have to scroll to the bottom to see the latest log results...

liuch commented 2 years ago

That's awesome! it looks really nice and clean.

Thank you! To be honest, I took the main ideas from one of github dark themes.

I have made a few edits that I think are worthy of a look

--color-st-txtblue is not like blue at all, more like white; --color-dg-wait and --color-tt-green look good; --color-tt-red became less noticeable than before. I'd set it to #f22;

You might also notice I swapped the log display order to newest-oldest as reading oldest-to-newest is a pain to have to scroll to the bottom to see the latest log results...

Yes, I've noticed your fix. I have slightly different habits and I don't have many entries in my log ((auto cleaning). But I am going to add that to the advanced settings. By the way, have you known you can swap the log display order by clicking on the column title?

kramwell commented 2 years ago

--color-st-txtblue is not like blue at all, more like white; --color-tt-red became less noticeable than before. I'd set it to #f22;

The old colour was like a dark purple for me which I think is too dark for the dark-mode, same for the red colour but that seems too bright when switched to dark-mode. Ill poke around Github and see what they might have defined as examples...

I have slightly different habits

This is great, as I said before I am by no means an expert in this but I do like to tinker alot. So its great that you can take an idea from someone and make it in a way that works for you and the codebase and more importantly contributes overall to the project.

have you known you can swap the log display order by clicking on the column title?

Yes but it reset every time you refresh. for me I will rarely delete the logs (maybe after 1 year or something) as its certainly valuable info to have in a business setting and to look back on if needed or asked.

Looking forward to the newest revisions!

liuch commented 2 years ago

Yes but it reset every time you refresh.

I added an option to the advanced settings: https://github.com/liuch/dmarc-srg/commit/05412d76250f9d90e9178e8beb65496d379218ec

kramwell commented 2 years ago

Love it! the new additions are great and the dark theme is looking really good now and the log order settings is a nice touch!!

I was looking at some new things that could be introduced and would like to hear your thoughts...

-Manually check for new reports, A button you could press to manually check for new reports (instead of wating for the cron job or going into the ssh directly) a button would be useful.

-Custom timestamp, Change timestamp to unix and then let php ini choose the timezone, a setting could then be added to choose which timezone you want to display that updated the php ini, (example- my webserver is in US but im in EU so time is not correct)

liuch commented 2 years ago

Thanks for your inspiring words!

Manually check for new reports

You are right, that would be useful.

Custom timestamp

My timezone and my server's timezone don't match either. I initially set the time on the server to UTC, incoming reports also come to UTC, it is UTC in the database too (perhaps not everywhere, I should check it out). I generate final reports once a week, so this is never a big problem for me. I will try to do something with the time settings.

Could you specify for which timestamps you would like to have a timezone setting? Why shouldn't it be the browser local timezone? I think it would be better if you create a new issue for that and close this one.

kramwell commented 2 years ago

Awesome, I will close this and open new ones with the two things mentioned here.

That is an even better idea to take the browser local time!