Fix layout - Githubissues

liuch / dmarc-srg

A php parser, viewer and summary report generator for incoming DMARC reports.

GNU General Public License v3.0

218 stars 32 forks source link

Fix layout #39

Closed smeinecke closed 1 year ago

smeinecke commented 1 year ago

This fixes some layout problems:

Fixes limited space in header for counters + print count in local format.
Static size of badges to contains size, regardless if report is marked read or unread.
Unform format of datetime regardless if localtime or utc is selected.

liuch commented 1 year ago

I would merge some of the commits from your PR, but not all. For example, I don't like the commit in which you set a css rule width: 3em;. What if I set the following rule: text-transform: lowercase; or even text-transform: full-width;? Maybe it should be min-width? But I still don't like this one. There is too little space in the table to increase the width of its elements.

liuch commented 1 year ago

Could you break the PR into logically separate entities? It would be easier to decide what to accept and what not.

liuch commented 1 year ago

Have a look at this: https://github.com/liuch/dmarc-srg/commit/3a48021ffbd15c15de357ae37619435bfed20e88. I have changed the colors (your are almost the same in the dark theme and too bright) and prevented a button based on a link from changing color.

williamdes commented 1 year ago

Hi @liuch Can we close this old one ? Is the changes to the formatting already merged ?