search

liuch / dmarc-srg

A php parser, viewer and summary report generator for incoming DMARC reports.
GNU General Public License v3.0
218 stars 32 forks source link

Show quarantined and rejected numbers #54

Closed robdewit closed 1 year ago

robdewit commented 1 year ago

Failing DKIM or SPF can also be the result of bad (internal) forwarding, so it might be interesting to also show what decisions the reporting servers made regarding the received email.

I added the disposition results to the email summary and in the UI it is part of the listing. In the filter settings I have added disposition. Choosing "quarantine" will also show "rejected" as in that I case would be also interested in those failures. Another option would to just choose between "any" and "failures", but this allows for more precision.

liuch commented 1 year ago

Could you use spaces instead tabs in php code, please? I like tabs too, but stick to PSR-2 in php.

robdewit commented 1 year ago

I pushed some easy no-brainer commits. I can take a look at the others, but I'm not sure what to do, so I'll wait for outcome of review discussions.

liuch commented 1 year ago

Can this be merged ? Or is more testing needed ?

I like this PR, except for extra columns in the web ui and reports. Columns need to either be combined with the messages column or make their display customizable (for the web ui). I still don't know what to do with the summary report.

robdewit commented 1 year ago

I've since moved on to another solution and my UI skills are very limited so I won't make any changes anymore.

Feel free to copy/add/change whatever in this PR.

williamdes commented 1 year ago

I've since moved on to another solution and my UI skills are very limited so I won't make any changes anymore.

Feel free to copy/add/change whatever in this PR.

Can you grant me access to your fork repository? I will apply the changes needed

williamdes commented 1 year ago

@robdewit can you rebase this PR or grant me access to it ? else @liuch can you close it ?

I was applying it with my script but now that it has conflicts that's an issue

Thanks for the closing @liuch Part of this was merged into 593b8b565b56a7148eec0f84f03de192f23e7050 I think

The work will continue in https://github.com/liuch/dmarc-srg/pull/80