search

liuch / dmarc-srg

A php parser, viewer and summary report generator for incoming DMARC reports.
GNU General Public License v3.0
218 stars 32 forks source link

Improvements and fixes #74

Closed williamdes closed 1 year ago

liuch commented 1 year ago

Thanks a lot!

williamdes commented 1 year ago

Are you interested by running the phpunit tests in GitHub CI ? It's only a file in .github

With that I could also add phpstan support

williamdes commented 1 year ago

I also have a very well working Docker nginx PHP 8.1 Linux alpine version

liuch commented 1 year ago

I'd rather not be tied to a specific platform. Phpunit perfectly runs locally. But I definitely need to increase my test coverage.

With that I could also add phpstan support

What do you mean by that?

I also have a very well working Docker nginx PHP 8.1 Linux alpine version

I don't know enough about how docker works, and I try not to add things to the project that I don't understand. But a link to your Dockerfile can be placed in the README.md file if you like.

williamdes commented 1 year ago

I did open #76 for the phpstan subject if it pleases you I may continue or at least push a script for you to play with it and improve the code base level by level