search

liuch / dmarc-srg

A php parser, viewer and summary report generator for incoming DMARC reports.
GNU General Public License v3.0
218 stars 32 forks source link

More phpstan fixes #78

Closed williamdes closed 1 year ago

williamdes commented 1 year ago

I fixed one actual unreachable code in 59d638d547a72889ad7ff6ae72bda1446ef10175

The other changes are purely phpdocs

That said I am not sure about the phpdoc ones for DatabaseConnector since the comment was @param Connector $connector DatabaseConnector. Let me know

williamdes commented 1 year ago

That all for this PR: Found 423 errors left 😄 Mostly phpdocs

williamdes commented 1 year ago

Thank you @liuch for making the changes I was missing time to get back to this this week

liuch commented 1 year ago

It's okay.