search

liuchengxu / eleline.vim

:herb: Another elegant statusline for vim
MIT License
311 stars 79 forks source link

Make eleline more elegant #42

Open rockyzhang24 opened 3 years ago

rockyzhang24 commented 3 years ago

Hello Liucheng,

First, I really appreciate your efforts to make this elegant status line plugin 👍 . I have been using it for a long time. This time, I want to make it more elegant and complete.

Below I attached a screenshot to show its final looking

image

How are you feeling? 🤗

Changes I made:

  1. I added three new items I believe they are very general for most users, especially the first one, i.e., the mode indicator.
    • Mode indicator (the first item): shows which mode vim is currently in such as N for Normal, V for Visual, and C for Command, and its background color will be changed based on the different mode.
    • Scroll bar (next to the percent item): indicates the position where the current line is
    • Devicon (next to the filename)
  2. I tweaked some existing items such as the "buffer and window number" item to make them clearer and more compact
  3. Code clean and refinement
    • Vim said user-defined functions should start with a capital letter so I adjusted the function names
    • Changed some variable names to make them more descriptive such as changing Eleline7 to ElelineFileType
    • Improved the coding style to make it more readable such as adding space on each side of the string concatenate operator .
  4. I removed a little piece of code regarding the adaption of the light themes because, in my opinion, eleline's looking under light themes is not as perfect as its looking under dark themes. If someone prefers a light theme, he/she can modify the code easily referring to the way how we handle dark themes.

If you think this is not useful, it doesn't matter, and feel free to ignore this PR. Or you can merge some parts you like 😁 . At least, this PR can be used as a reference for other users who want to customize eleline.

If you accept this, I will open another PR to update the README.

Thank you very much. 谢谢～