search

liuchengxu / space-vim-dark

:purple_heart: A dark colorscheme for space-vim, see space-vim-theme for light background support!
MIT License
599 stars 74 forks source link

Add space-vim-dark Xresources theme #12

Closed axvr closed 6 years ago

axvr commented 6 years ago

This will allow X based applications (such as, Xterm & URxvt), to use the beautiful Space-Vim-Dark theme.

This will partly solve issue #10.

The colours still need switching around (make the purple the main colour?), but it is using all (16) of the main space-vim-dark colours.

Feedback is appreciated. @liuchengxu feel free to modify, and criticise my this. 😄

To Do

Images of initial version in URxvt

first-version

first-version-htop

Comparison to Vim in URxvt using Space-Vim-Dark colour scheme

vim-space-vim-dark

liuchengxu commented 6 years ago

Looks good, @axvr 👍 . It's fine to make the purple(or the blue?) the main color in my opinion.

axvr commented 6 years ago

I have done some more improvements to the Xresources port of the space-vim-dark theme, I have added some additional documentation to the comments in the file; these include how to use the theme.

The colours have been defined in terms of the Base16 colour architecture, this provides the added benefits of once you have defined the 16 colours (which are all described on the site) the colour theme can be easily ported to other platforms using the many templates which they provide.

I am however a bit unsure of the colours you would like to be used, so I have included comments explaining how it works and how to modify the colours (requiring only editing the section with is labelled as ! 'Base16' Style colour definitions) if you wish to do so in the future, or fix some of the colours (if any help is needed you can contact me using @axvr on this PR or an Issue).

I have also managed to emphasise the violet colours, but I am not sure if it is an improvement or not, so I would like your opinion on the change, or how it could be improved.

comparison

When you believe this port is ready, you can merge it if you wish to do so.

liuchengxu commented 6 years ago

Looks great! @axvr Thanks for your effort, this is awesome! I'll update the README.md later so that you could keep your credit :).