liuchengxu / vista.vim

:cactus: Viewer & Finder for LSP symbols and tags
https://liuchengxu.github.io/vista.vim
MIT License
1.89k stars 87 forks source link

Colors aren't adjustable and look off with nord theme #336

Closed Folling closed 4 years ago

Folling commented 4 years ago

Describe the bug I setup Vista just now, and it seems to be using the wrong colours of the palette.

Environment:

Vista info I'll add this if it's required afterwards, I presume it won't be necessary, since this is either an issue on my end, or with vista's colour decisions.

Steps to reproduce given the above info

  1. Download kitty
  2. Setup the nord theme manually (no pre-made version available, all you need to do is replace the colours in the kitty config with the ones from the nord palette. I've used this as a baseline: https://gist.github.com/marcusramberg/64010234c95a93d953e8c79fdaf94192
  3. Open a c++ file
  4. ???
  5. Profit

Expected behaviour I'd expect vista to use the colours as specified for my colour palette properly. Ideally it would be configurable. The parent-title looks fine, though the children would probably be better off using a lighter colour. Additionally, the highlighted text-colour is invalid.

Actual behaviour See below

Screenshot or GIF (if possible) Here's a screenshot of the Vista preview: image Especially the selected text is almost unreadable. For comparison, here's a screenshot of some normal cpp file: image As you can see, the selection is a lot more readable.

I apologise if I just overlooked something simple. I'm not that great with terminals or vim in general. I've checked the entirety of :help vista-options and didn't find anything to adjust colours. I've also looked online to see if it's possible to adjust the colours for just one vim window, but wasn't successful. Thank you very much for the extension though, it's exactly what I've been looking for!

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.91. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

liuchengxu commented 4 years ago

The highlights in vista are mostly linked to your colorscheme's highlight group, see https://github.com/liuchengxu/vista.vim/blob/master/syntax/vista.vim, so it's not problem of vista. You can change that easily if you prefer another highlight group, ref :h :hi-default.