liuchengxu / vista.vim

:cactus: Viewer & Finder for LSP symbols and tags
https://liuchengxu.github.io/vista.vim
MIT License
1.88k stars 89 forks source link

Indent icon setting does not work for coc executive #393

Closed rockyzhang24 closed 3 years ago

rockyzhang24 commented 3 years ago

Describe the bug let g:vista_icon_indent doesn't work for the coc executive. In README, I saw "this option only works the LSP executives", does is mean that it only works for the vim_lsp executive, or all LSP based executives?

Thank you so much.

Environment:

Vista info

Current FileType: javascript

Avaliable Executives: ['coc', 'ctags'] Global Variables: let g:vista = {'get_tagline_under_cursor': function('36'), 'winnr': function('34'), 'silent': v:false, 'source': {'fpath': '/Users/yanzhang/gitrepos/leetcode-cli/lib/cli.js', 'bufnr': 2, 'get_winid': function('38'), 'fname': 'lib/cli.js', 'winnr': 1, 'extension': function('43'), 'line': function('41'), 'get_winnr': function('37'), 'filetype': function('39'), 'lines': function('40'), 'winid': 1000, 'line_trimmed': function('42'), 'scope_seperator': function('44')}, 'provider': 'coc', 'winid': function('35'), 'tmps': []} let g:vista#executives = ['ale', 'coc', 'ctags', 'lcn', 'nvim_lsp', 'vim_lsc', 'vim_lsp'] let g:vista#extensions = ['markdown', 'rst'] let g:vista#finders = ['clap', 'fzf', 'skim'] let g:vista#render#enable_icon = 1 let g:vista_blink = [2, 100] let g:vista_close_on_fzf_select = 0 let g:vista_close_on_jump = 0 let g:vista_cursor_delay = 400 let g:vista_default_executive = 'coc' let g:vista_disable_statusline = 0 let g:vista_echo_cursor = 1 let g:vista_enable_centering_jump = 1 let g:vista_executive_for = {} let g:vista_find_absolute_nearest_method_or_function = 0 let g:vista_find_nearest_method_or_function_delay = 300 let g:vista_fold_toggle_icons = ['▼', '▶'] let g:vista_fzf_preview = ['right:50%'] let g:vista_icon_indent = ['╰─▸ ', '├─▸ '] let g:vista_ignore_kinds = [] let g:vista_no_mappings = 0 let g:vista_sidebar_position = 'vertical botright' let g:vista_sidebar_width = 50 let g:vista_stay_on_open = 1 let g:vista_top_level_blink = [2, 100] let g:vista_update_on_text_changed = 0 let g:vista_update_on_text_changed_delay = 500

Steps to reproduce given the above info

Just open any file. I opened a js file for the testing.

Thank you.

liuchengxu commented 3 years ago

Sorry for the late reply, I have updated the comment about g:vista_icon_indent, which works only for the kind renderer.

rockyzhang24 commented 3 years ago

Thank you. So it means that g:vista_icon_indent only works for the ctags and g:vista#renderer#ctags must be set to kind, right?

liuchengxu commented 3 years ago

Not really, both LSP and ctags can use the kind renderer.

Rocky Zhang @.***> 于2021年3月31日周三 下午11:55写道:

Thank you. So it means that g:vista_icon_indent only works for the ctags and g:vista#renderer#ctags must be set to kind, right?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/liuchengxu/vista.vim/issues/393#issuecomment-811176722, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDQWSAX3SUC3G6HUJLEDZDTGNAWFANCNFSM4ZG7Z7CQ .

rockyzhang24 commented 3 years ago

How to use the kind renderer for LSP, g:vista#renderer#lsp? Specifically, I am using coc.nvim, how should I config it to use kinder renderer? I cannot this in the help doc. Thanks a lot.

liuchengxu commented 3 years ago

No such option, coc uses the tree renderer, the other LSP clients use the kind renderer.

Rocky Zhang @.***> 于2021年4月1日周四 上午8:46写道:

How to set the kind renderer for LSP? g:vista#renderer#lsp? I cannot this in the help doc. Thanks.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/liuchengxu/vista.vim/issues/393#issuecomment-811559224, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACDQWSENTN27TG4T2JFGRD3TGO7AFANCNFSM4ZG7Z7CQ .

rockyzhang24 commented 3 years ago

Okay. So what you mean is that if I use LSP clients other than coc, the default renderer is kind, right? Thanks.

liuchengxu commented 3 years ago

Yes, the other LSP clients only support the kind renderer right now.

rockyzhang24 commented 3 years ago

I see. Thank your.