vista tries to scroll wrong window

[vatosarmat]

Describe the bug

1. Configure cursor strategy to 'scroll' and cursor position to left. Open Vista coc to the left of the source window, press j several times, see how vista side window flickers trying to scroll itself.
2. Configure cursor strategy to 'scroll'. Open Vista coc to the right of the source window. Then open coc-explorer, then return focus to 'Vista'. Press 'j' several times, see how vista scrolls 'coc-explorer' instead of the source window.

Environment:

• OS: Ubuntu 18.04
• Vim/Neovim version: Neovim 0.5 nightly
• This plugin version: the latest
• I'm using universal-ctags: yes
• I'm using some LSP client: coc

Vista info let g:vista_sidebar_position = 'vertical topleft' let g:vista_sidebar_width = 60 let g:vista_cursor_delay = 0 let g:vista_echo_cursor_strategy = 'scroll'

winnr is a volatile value. Why does Vista use it and not buf_id and win_id to identify window when scrolling? This fixes the issue

   let source_handle = {}

   function! source_handle.get_winnr() abort
-    if has_key(self, 'winnr')
-      return self.winnr
-    else
       return bufwinnr(self.bufnr)
-    endif
   endfunction