liuchengxu / vista.vim

:cactus: Viewer & Finder for LSP symbols and tags
https://liuchengxu.github.io/vista.vim
MIT License
1.88k stars 89 forks source link

Option for hiding text kind when icons enabled (#408) #412

Closed emarbo closed 2 years ago

emarbo commented 2 years ago

Pull request for: https://github.com/liuchengxu/vista.vim/issues/408

This PR adds a new option g:vista#renderer#enable_kind for hiding the textual representation of the kind. This option defaults to !g:vista#renderer#enable_icon because once icons are enabled the textual representation is redundant. Anyway, both options are compatible and users can enable both if they want.

I also, removed the extra spaces when the textual kind or icon kind are empty.

SCREENSHOTS

coc, icon 1, kind 0 coc_icon_1_kind_0

coc, icon 1, kind 1 coc_icon_1_kind_1

ctags, icon 1, kind 0 ctags_icon_1_kind_0

ctags, icon 1, kind 1 ctags_icon_1_kind_1

emarbo commented 2 years ago

Hello @liuchengxu, have you got time to check this PR? It's the related to #408. Thanks in advance

liuchengxu commented 2 years ago

Sorry for being late, merged, thank you!