liuchengxu / vista.vim

:cactus: Viewer & Finder for LSP symbols and tags
https://liuchengxu.github.io/vista.vim
MIT License
1.88k stars 89 forks source link

Reset nvim_lsp_fetching to true before RunAsync #439

Closed lizhemingi closed 1 year ago

lizhemingi commented 1 year ago

Resolve #438

lizhemingi commented 1 year ago

This fix problem in my local environment.

Please take a look. @liuchengxu

liuchengxu commented 1 year ago

This will probably fix CI

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 03d6f80..46f98ba 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
     - name: Checkout
       uses: actions/checkout@master
     - name: Run vint with reviewdog
-      uses: reviewdog/action-vint@v1.0.1
+      uses: reviewdog/action-vint@v1
       with:
         github_token: ${{ secrets.github_token }}
         reporter: github-pr-review
lizhemingi commented 1 year ago

This will probably fix CI

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 03d6f80..46f98ba 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -13,7 +13,7 @@ jobs:
     - name: Checkout
       uses: actions/checkout@master
     - name: Run vint with reviewdog
-      uses: reviewdog/action-vint@v1.0.1
+      uses: reviewdog/action-vint@v1
       with:
         github_token: ${{ secrets.github_token }}
         reporter: github-pr-review

Seems a newer version of reviewdog/action-vint also fix the problem. Should I file another pr or you will have some other way to deal with it? @liuchengxu

lizhemingi commented 1 year ago

I have added a commit int this pr to change "action-vint" to v1, can you have another try on CI ? @liuchengxu

liuchengxu commented 1 year ago

Merged, thanks!