search

liuchengxu / vista.vim

:cactus: Viewer & Finder for LSP symbols and tags
https://liuchengxu.github.io/vista.vim
MIT License
1.88k stars 89 forks source link

Echo error explicitly #458

Closed jiz4oh closed 1 year ago

jiz4oh commented 1 year ago

Hi @liuchengxu, 非常感谢你创建了这么 Nice 的插件，不过在使用途中发现一些小小的问题，比如我自定义了 ruby 文件使用 ripper-tags 解析，但是因为我的 typo 我始终无法正确显示 ctags 侧边栏，最终花费了大量时间定位问题。

image

之前的异步处理没有处理错误情况，当 shell 命令失败之后直接静默掉，即使启用了 g:vista_log_file 也无法定位问题，这个 pr 增加了一些错误处理的逻辑，可以将错误直接提示给用户，减少用户发起 issue 的可能。

liuchengxu commented 1 year ago

Thank you!

lpyparmentier commented 11 months ago

This should be reverted (or adapted), it brings an annoying message that ctags is not available while I dont need it because my vista_default_executive is ALE. Each time I open a file, I got the error.

image

liuchengxu commented 11 months ago

@lpyparmentier The log is pretty useful in certain situations, therefore, I'd like to keep it. The fix for this particular annoying message looks easy, but I'm not sure it would prevent the other potential edge cases. Could you please create a new issue with the related minimal vimrc config?