liud4 / rVMAP

Data Management code for VMAC-MAP study
Other
3 stars 0 forks source link

invalidate_neuropsych_eligibility() needs update! #20

Closed liud4 closed 5 years ago

liud4 commented 5 years ago
  1. map_id instead of map.id should be used;

invalidate_neuropsych_eligibility() was applied at the bottom of process_eligibility() to a dataset with the variable "map_id", but not "map.id". However, "map.id" is used in invalidate_neuropsych_eligibility() to indicate MAP IDs with invalid values.

  1. np_digitsf related variables should be renamed to np_wais_digitsf in eligibility database; Per Kim's Asana massage in Task Data Dictionary Updates on 12-03-2018. Below is the update: x7 <- c( "np_wais_digitsf_elig", "np_wais_digits_elig", "np_wais_digits_ss_elig", "np_wais_digitsf_span_elig", "np_wais_digitsf_span_z_elig" )
omair-a-khan commented 5 years ago

@liud4, thanks for catching the error in map_id.

Question: for MAP ID "016" and "213," the only two variables we are setting to missing are "np_blocks_elig" and "np_blocks_ss_elig." The variable "np_srt_immed_elig" is set to missing for only MAP IDs "007" and "025." Is this what you meant? Or should 016 and 213 also have this variable set to missing?

omair-a-khan commented 5 years ago

@liud4 , can you check on this so I can update the function in the package? Thanks.

liud4 commented 5 years ago

@fullstackstatistician Yes. I just deleted the comment related to 016 and 213. I do not recall why I put that comment. I must mess it up with 007. I checked your updated to this function and it is correct.

Thanks,