liuderchi / atom-i18n

:atom: One Atom i18n Package for Any Locale :earth_asia: :earth_americas: :earth_africa:
https://atom.io/packages/atom-i18n
MIT License
75 stars 69 forks source link

Can not localize Welcome-view #297

Closed juggernautjp closed 3 years ago

juggernautjp commented 3 years ago

Prerequisites

Description

"Welcome" view is not localized.

Steps to Reproduce

  1. Click "Settings" in "File" menu
  2. Click "Packages" in "Settings" view
  3. Click "Enable" in "atom-i18n" package
  4. Click "Settings" of the "atom-i18n" package
  5. Set "Language" to "???(ja)" in the list
  6. Click "Welcome" in "Help" menu
  7. "Welcome" view is appeared

Expected behavior: Some English words in "Welcome" view and sentences are localized.

Actual behavior: "Welcome" view has some English words.

Reproduces how often: Always

Versions

- Atom    : 1.55.0
- Electron: 6.1.12
- Chrome  : 76.0.3809.146
- Node    : 12.4.0

Additional Information

image

TODO

liuderchi commented 3 years ago

@juggernautjp Thanks for your contribution! Your fix has been published in v0.25.1 https://atom.io/packages/atom-i18n