search

liuderchi / ide-css

:atom: Atom-IDE for CSS, LESS and SCSS language
https://atom.io/packages/ide-css
16 stars 1 forks source link

Remove help command #34

Closed vinkla closed 5 years ago

vinkla commented 5 years ago

This pull request removes the help command feature. I would argue that this command isn't necessary. If user's need help with using this package they can rely on the default Atom behaviour by visiting the package in the settings. From an UX point of view I think this will scare off new users since a big welcome notification popup. I would also argue that this package should be similar to other packages such as ide-typescript and ide-php. Keeping this package light, simple and only have it as a bridge for Atom and vscode-css-languageserver-bin.

liuderchi commented 5 years ago

From an UX point of view I think this will scare off new users since a big welcome notification popup.

Actually registerHelpCommands() do not actively shows any Welcome notification popup. What it does:

  1. provides a command ide-css:help listing out all commands ide-css supports (in notification popup)
  2. Provide 2 links (as button) to navigate user to FAQ or GH issue pages
vinkla commented 5 years ago

Yeah, you're right. I'm mixing this with the ide-html package. Sorry for the noice.

liuderchi commented 5 years ago

Never mind 👋 Welcome to discuss it in https://github.com/liuderchi/ide-html