liuderchi / ide-css

:atom: Atom-IDE for CSS, LESS and SCSS language
https://atom.io/packages/ide-css
16 stars 1 forks source link

Add activationHooks #39

Closed aviatesk closed 5 years ago

aviatesk commented 5 years ago

Hi, this PR suggests ide-css uses activationHooks for better loading time.

Purpose

Introduce actiavationHooks:

Notes

The difference from enhancedScopes:

Fallbacks

I've never noticed the downside of this change

Misc

You can see ide-typescript, the officially maintained Atom-IDE package, uses this logic as well: https://github.com/atom/ide-typescript/blob/master/package.json#L68-L73

aviatesk commented 5 years ago

@liuderchi Anymore update on this ? Or are you just against this change ?

liuderchi commented 5 years ago

@aviatesk Sorry for the late response. Let's merge it!

aviatesk commented 5 years ago

Thanks so much for merging !

I would appreciate if you would make an new release, so that I can use it on different machine easily ;)

liuderchi commented 5 years ago

@aviatesk v0.3.3 has just released 🙂