liuderchi / ide-html

:atom: Atom-IDE for HTML, Go Template, Mustache and other Templates
https://atom.io/packages/ide-html
MIT License
20 stars 5 forks source link

Added Angular (text.html.ng) support #10

Open egesu opened 6 years ago

egesu commented 6 years ago

It already works when I put text.html.ng in additional grammars, however I thought this option is for optional extensions like backend languages. text.html.ng is always a frontend code, and no problem to put it in defaults.

By the way, text.html.ng is from language-html-angular package.

liuderchi commented 6 years ago

@egesu additional grammars is not designed for backend languages only; it's a flexible, experimental config for grammars supported by community packages. By doing so we keep scope of ide-html not too big.

IMO suitable config for text.html.ng is either


How do you think ---

liuderchi commented 6 years ago

@egesu any feedback to my comments?

egesu commented 6 years ago

Sorry about the delay. Additional grammars solves the issue very well, however the problem is when I wanted to use this feature, I had to find the grammar name for language-html-angular package. I didn't know anything about the grammars before, so I had to spend some time on it. Probably for a newbie in web development, additional grammars won't solve the issue. So I think checkbox would be nice.

I will update the PR as soon as possible.

liuderchi commented 6 years ago

... So I think checkbox would be nice.

@egesu That sounds Great!

IMO the description need to be informative by telling user that this checkbox requires atom package language-html-angular