search

liudongmiao / bible

offline bible
58 stars 40 forks source link

Section headings should not be part of following #16

Open nljelfs opened 5 years ago

nljelfs commented 5 years ago

From the text (which is from Bible Gateway), heading is part of the verse. For version from Bibles.org, heading is not part of the verse. And when I make Bible from ebible.org, I make heading part of the verse like Bible Gateway.

Headings are not part of the original Bible text (they are inserted by translators) so I don't think they should be part of the verses in Dove Bible (ie should not be highlighted when a verse is highlighted)

liudongmiao commented 5 years ago

And, make subtitle part of verse, so subtitle can be searchable.

liudongmiao commented 5 years ago

I'd like heading is part of verse.

  1. it will make heading searchable.
  2. from ebible.org or BibleGateway, heading is part of verse.
  3. Bibles.org don't regard heading as part of verse.
nljelfs commented 5 years ago

Thanks for the update. In case you're not aware, the headings are not part of the original text - they are added by the translators. So I think it's better that they are not part of the verse for highlighting, search, etc.

Is there a technical reason why headings are not searchable unless they are part of a verse? Can the search function be improved to search both headings and verses at the same time?

liudongmiao commented 5 years ago

From the original source:

If headings are part of the source, it can make headings searchable in a very easy way.

Actually, it's possible to make headings not part of the Text, it can be simple:

It may be an option, like this:

So, what's your idea for the headings:

stevebaros commented 4 years ago

Is this repo still maintained ?

liudongmiao commented 4 years ago

Yes, however, the latest source code are not uploaded.