search

liufengyun / gestalt

gestalt : portable and solid macros for Scala
https://github.com/scalacenter/macros
31 stars 3 forks source link

Change Seq to List in all APIs #84

Closed liufengyun closed 7 years ago

liufengyun commented 7 years ago

Only the last commit is new

valdisxp1 commented 7 years ago

Is it for performance reasons? The changes look good, I just do not understand, why?

liufengyun commented 7 years ago

The change is not easy to justify, I'd say it's more of a preference -- as List is more well-known in functional programming.

Nevertheless, I think have List in return types is better. But if we use Seq in params, List in return types, it will cause some oddity, aesthetically at least. So, in turn I decided to change everything to List.