liufengyun / gestalt

gestalt : portable and solid macros for Scala
https://github.com/scalacenter/macros
31 stars 3 forks source link

refactor design of InitCall #90

Closed liufengyun closed 7 years ago

liufengyun commented 7 years ago

@valdisxp1 I did the refactoring for InitCall. It will be much easier for you to refactor NewInstance based on this PR.

The most important motivation for making qual, name, targs explicit in the constructor is to make the extractor more friendly. The consideration for semantic difference is secondary.

I'd like to abandon the original design due to following reasons:

type A = Some[Int]
new A(3)
liufengyun commented 7 years ago

Thanks @valdisxp1 !