search

liufengyun / hashdiff

Hashdiff is a ruby library to to compute the smallest difference between two hashes
MIT License
559 stars 63 forks source link

Adds Rubocop #47

Closed stephengroat closed 5 years ago

stephengroat commented 5 years ago

Adds rubocop and rubocop-rspec to project to run with rake and fixes any issues

no functionality changes made, only syntactical. if there's something i changed away from a preference, let me know and i can switch it back. rubocop seems to really help with ruby linting

liufengyun commented 5 years ago

Thanks a lot @stephengroat , it seems the CI is not happy with the last commit.

Generally I'm happy with the PR.

stephengroat commented 5 years ago

@liufengyun sorry about that, fixed!

liufengyun commented 5 years ago

Thanks a lot @stephengroat , LGTM 🎉