search

liufengyun / hashdiff

Hashdiff is a ruby library to to compute the smallest difference between two hashes
MIT License
560 stars 63 forks source link

Remove warning #67

Closed liufengyun closed 5 years ago

liufengyun commented 5 years ago

Fix #66: Remove warning

liufengyun commented 5 years ago

@jfelchner WDYT?

krzysiek1507 commented 5 years ago

I think the warning should be here. Only HashDiff should be deprecated.

krzysiek1507 commented 5 years ago

Or you can remove the warning and release 1.0.

jfelchner commented 5 years ago

@liufengyun No we shouldn't merge this. Unless it's causing issues, the warning needs to remain until 1.0. And we shouldn't release 1.0 just yet.

jfelchner commented 5 years ago

If webmock had a < 1.0 in their gemspec, we could release 1.0 right now, but they don't. So if we upgrade hashdiff to 1.0 before they merge my PR, we'll break every webmock install. 💣

liufengyun commented 5 years ago

Thanks a lot @krzysiek1507 @jfelchner .

/cc: @grosser, do you have any proposals?

grosser commented 5 years ago

My order of preference:

jfelchner commented 5 years ago

@grosser without a warning, there's less of a chance they're going to update, which means there's more of a chance it's going to break their apps. We have had people be driven to the GH issue specifically because of the warning.

If you know of a way to make the warning show only when using the deprecated constant, I'm all for that solution, but I don't know how to do that.

grosser commented 5 years ago

there is no update, so people just come here and complain, that's not a solution 🤷‍♂ ... remove the warning and add it back once there is a v1 and nobody would have opened an issue

jfelchner commented 5 years ago

@grosser I opened the issue. Before the warning was even added. And we would release a v1 if it were possible, but it is not yet until we get a new webmock version released.