search

liufengyun / hashdiff

Hashdiff is a ruby library to to compute the smallest difference between two hashes
MIT License
560 stars 63 forks source link

Can’t silence HashDiff constant warning #68

Closed tomstuart closed 5 years ago

tomstuart commented 5 years ago

Thanks to the warning from #65, I am now aware of the HashDiff/Hashdiff conflict. I have updated my code to use the correct Hashdiff constant.

Now that I’ve done the work to fix the issue, how do I turn the warning off?

jfelchner commented 5 years ago

@tomstuart we'll be releasing 1.0 shortly. We need to give webmock users a chance to upgrade to latest due to the way they had their dependencies specified.

nacengineer commented 5 years ago

@tomstuart one way is to put

$VERBOSE = nil

at the top of your gemfile. Just be aware this will silence all deprecation warnings.

jfelchner commented 5 years ago

@tomstuart I just realized we can release a beta for 1.0 which will allow people annoyed by the warnings to manually opt-in to the breaking change until we're ready to release 1.0 final. :)

See my comment on the original issue as well as this PR

tomstuart commented 5 years ago

@jfelchner That would be perfect. Thank you!

jfelchner commented 5 years ago

@tomstuart Awesome :) Can you close this issue please?

gshutler commented 5 years ago

In case anyone else ends up here and has to look up how to loosely define a beta version and upwards as you don't do it too often, this is about the same as ~> 1.0:

gem 'hashdiff', '>= 1.0.0.beta1', '< 2.0.0'