search

liuggio / StatsDClientBundle

Easily monitor your symfony2 production env., with ready-to-use stats.
MIT License
164 stars 43 forks source link

Remove classnames parameters #72

Closed ClementGautier closed 4 years ago

ClementGautier commented 5 years ago

This is an attempt to fix #68 While I was fixing this I noticed that some service definition needed to be changed in depth like the "sender". Unit tests are ok but I can't test it functionally right now, I hope you don't mind.

"Sender" definition review

The debug_class feature toggle made it unclear if you needed to specify a host/port/protocol depending on the sender implementation you were using. I removed this flag and the specific arguments and replaced it by an array of arguments.

About the dbal collector

I couldn't find the parameter liuggio_stats_d_client.collector.dbal.class anywhere so I guessed it (I'm not sur how it worked without that)

Happy hacktoberfest everyone :tada:

ClementGautier commented 4 years ago

Closing in favor of https://github.com/liuggio/StatsDClientBundle/pull/78 (updated version)