search

liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
475 stars 65 forks source link

Improve Behat list scenarios for Outline scenarios #108

Closed ClementGautier closed 7 years ago

ClementGautier commented 7 years ago

Hello,

I noticed that the ListFeaturesExtension, when used with list-scenarios consider Scenario Outline as one scenario but in our case they are the longest scenarios so it could be nice to split them as separated scenarios.

DonCallisto commented 7 years ago

LGTM either

ClementGautier commented 7 years ago

Oh, the implementation is different for Behat3, I do a quick update and push it again ;)

aitboudad commented 7 years ago

Thank you @ClementGautier!

ClementGautier commented 7 years ago

You are welcome ^^ Do you have an ETA of the release that will contain this change ?

aitboudad commented 7 years ago

done https://github.com/liuggio/fastest/releases/tag/v1.4.4

DonCallisto commented 7 years ago

@aitboudad please, try to considerate also other PR(s) open in order to make only one release. This, for instance, should have been 1.5.0 imho and should have been released along with https://github.com/liuggio/fastest/pull/104

It's not a big deal but, just for the future, please let's coordinate together (not only me, of course) to see what is the best approach for that kind of decision.

Do you agree?

aitboudad commented 7 years ago

sure, sorry just noticed there is no big changes introduced since v1.4.3 ;). I'll leaves you to handle the releases in order to avoid a such cases!

ClementGautier commented 7 years ago

Thx guys :)

DonCallisto commented 7 years ago

@aitboudad no worry and no pressure: it is not a big deal. I suggest just to talk each other; no matter who will create a release as long as we decide together. Don't worry to ask, I will certainly do the same with you and other collaborators as I'm pretty new to this project!

BTW, cheers, you guys just enhanced this tool, it's time to celebrate! 🎉