search

liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
473 stars 65 forks source link

Update code style to respect the PHP Coding Standards #124

Closed francoispluchino closed 6 years ago

francoispluchino commented 6 years ago
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

This PR update the code style to respect the PHP Coding Standards using the PHP Coding Standards Fixer.

DonCallisto commented 6 years ago

Wonderful: maybe we should hook something to check that cs-standards are respected?

francoispluchino commented 6 years ago

For Git you have this example. But for Github, I don't know.

francoispluchino commented 6 years ago

Last point on the quality, you have the URL of the project which redirects to a fucking website (http :// welcometothebundle.com/speedup-symfony-functional-tests-phpunit) !!! I guess initially this was not the case ;-)

francoispluchino commented 6 years ago

@DonCallisto If you do not see what I am talking about, your website link indicated for this repository (that is http://welcometothebundle.com/speedup-symfony-functional-tests-phpunit) redirects to that:

fastest_fucking_website

I think it's a serious problem, especially for the credibility of this tool!

DonCallisto commented 6 years ago

@francoispluchino I cannot edit this as I don't have privileges. I've wrote to @liuggio but he didn't reply yet.

BTW I'm waiting for your release note to take next step to 1.6 (I'll not be at home in the week end, so you have up to next Monday).

Thanks!

DonCallisto commented 6 years ago

@francoispluchino we have fixed all the things, now @liuggio added you as a collaborator (you need to accept his invitation): you can release 1.6 if you want: it's plenty of your contribution so you could proceed independently. Thanks again.

francoispluchino commented 6 years ago

@DonCallisto The v1.6.0 version is released.

DonCallisto commented 6 years ago

Thanks a lot!