search

liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
473 stars 65 forks source link

Fix renamed file loader in phpunit #127

Closed lsimeonov closed 6 years ago

lsimeonov commented 6 years ago

It was renamed from PHPUnit\Util\Fileloader to PHPUnit\Util\FileLoader in https://github.com/sebastianbergmann/phpunit/commit/3a9494be34135e5d42964ec7f5f17605e736a2c7#diff-7862e6eec2d5923e62d57728b79a0480

DonCallisto commented 6 years ago

Ok, this seems to be the only way to fix this, I didn't find a better solution. Just to more things, I would like to tag recently active collaborators like @tarlepp and @francoispluchino to have four more eyes on it before merging.

Moreover it would be great to start a discussion about this kind of BC that we want to keep: it's fantastic but, as we provide support for behat and phpunit, maybe we should have different major releases for majors of these libraries, with end of support for them, when them gonna stop support.

Moreover we should start thinking about "splitting" the project in three parts:

This way we could have more freedom for changes. Still don't know if core is "contaminated" with PHPUnit concepts though

Just random thoughts, let me know what do you guys think.

lsimeonov commented 6 years ago

Added more elegant way of handling case sensitive problem between PHP classes and composer autoloader. I also fixed a failing test where we don't mock the PHP_OS.

DonCallisto commented 6 years ago

Ok, I'm gonna merge this. TBH we should extend those tests even for other cases (don't know if it's easy to test the else branch actually) but this should not be included in this PR so it's perfectly fine to merge this.

Thank you for great effort!

DonCallisto commented 6 years ago

@lsimeonov here the release https://github.com/liuggio/fastest/releases/tag/v1.6.1 thank you again