search

liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
473 stars 65 forks source link

support of PHP 7.3 #130

Closed SailorMax closed 4 years ago

SailorMax commented 5 years ago

Can you recheck fastest with PHP 7.3? Looks like it broken when use 2+ parallel processes, but I can't find the reason... Part of unit tests return error.

Tested under Windows.

DonCallisto commented 5 years ago

PHP7.3 Is still RC version so we should not hurry on it. Let's wait for a stable release and then we can try all necesarry to reproduce and understand the issue, eventually. I close this for the moment.

SailorMax commented 5 years ago

@DonCallisto PHP7.3 is already RC! RC2! => this problem is unknown for PHP developers. I can't make for them real small sample of the problem for bug report. Possibly you, as developer of this program, can try to help them to find the problem.

DonCallisto commented 5 years ago

I know is RC. I'm just saying that we should not hurry until an "official" PHP7.3 version. BTW I can try to add PHP7.3 to travis matrix and see if tests fails. If they won't fail, I'll need you to replicate this issue in a fresh repo in order to understand what's going on.

SailorMax commented 5 years ago

Possible problem in Symfony/Process: https://github.com/symfony/symfony/issues/28655

DonCallisto commented 5 years ago

Nice catch, so it seems not to be a fastest issue. I'll subscribe to that topic. Thanks.

DonCallisto commented 5 years ago

@SailorMax I've merged this modification in master and it seems to work. Can you try it out and let me know? Thanks!

SailorMax commented 5 years ago

@DonCallisto Looks like it work now. Thanks!