search

liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
475 stars 65 forks source link

symfony 5 #147

Closed rulatir closed 4 years ago

rulatir commented 4 years ago

Please bump symfony version again!

DonCallisto commented 4 years ago

Please, before opening a new issue, try to search if something realted is already there. Check #143 and #146. Moreover, open source works better if instead of asking, you'll (generic) try to contribute. BTW I close this as two issue are already in place for this kind of task.

rulatir commented 4 years ago

There's a tradeoff between spending some more time searching for similar issues vs. searching a little less thoroughly (think 9/10 instead of 10/10) and posting a new issue. Sometimes something will slip through the crack between these two options. Please don't assume laziness.

DonCallisto commented 4 years ago

I didn’t assumed anything here. Just pointed you to already opened PRs and suggested to search before opening a new issue. I don’t think that searching into an input box is slower than opening a new PR. Just think for a moment what implies to have some opened issues pointing to same request, if no one searches anymore. I don’t think the so called trade-off is worthy in such cases.

DonCallisto commented 4 years ago

See https://github.com/liuggio/fastest/pull/149

DonCallisto commented 4 years ago

@rulatir check #149 please and give it a try and a feedback. Thanks.