search

liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
473 stars 65 forks source link

handle mysql master / slave connection #159

Open jdeniau opened 3 years ago

jdeniau commented 3 years ago

Actually, the $dbName is computed either from $params['dbname'] on $params['master']['dbname'] and override only the dbname parameter (not the master one) and there is no slave management except for sqlite.

This PR compute the dbname from the mysql connection and replace both dbname, master's dbname and all slaves dbname.

I test if the driver is pdo_mysql, but it might be the default case, what do you think ?

DonCallisto commented 3 years ago

I didn't had the chance to take a look at this. Would you mind to rebase this? Moreoever I can't guarantee I'll have much free time to review this, but sooner or later I'll do. Thanks.

jdeniau commented 3 years ago

@DonCallisto rebase done.

Take the time you need for the review, I'm using my patched version for the moment.

Thanks for maintaining this library !

DonCallisto commented 3 years ago

Doing my best with my little free time. Thank you for contributing.