search

liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
475 stars 65 forks source link

Fix for #49 #50

Closed rbaarsma closed 8 years ago

rbaarsma commented 8 years ago

always add current ENV vars, to prevent errors using MAMP (and most likely other setups)

See also https://github.com/liuggio/fastest/issues/49

liuggio commented 8 years ago

@rbaarsma thanks a lot, but the test: tests/Process/ProcessFactoryTest.php fails please would like to fix the test commit the new file and then git stash into a single commit (with something like git rebase -i HEAD~2 more info at http://symfony.com/doc/current/contributing/code/patches.html#rebase-your-patch)

rbaarsma commented 8 years ago

Sorry on holiday until 16. Maybe then

liuggio commented 8 years ago

thanks @rbaarsma your code has been merged