liuggio / fastest

Simple parallel testing execution... with some goodies for functional tests.
MIT License
473 stars 65 forks source link

Use putenv to set fastest enviroment variables. #58

Closed ioleo closed 8 years ago

ioleo commented 8 years ago

As suggested by @Seldaek we're passing null to Symfony's Process component, which results in useing current ENV variables. Just before creating the process we use putenv to inject fastest variables. This solution does not depend on php.ini settings.

ioleo commented 8 years ago

@liuggio squashed into one commit <3

ioleo commented 8 years ago

@liuggio What about this PR, can I merge it?

ioleo commented 8 years ago

Merged as this does not introduce any BC breaks, and fixes some problems with enviroment. Also the general rule for subprocesses is they inherit parents enviroment and this is how this PR works.