search

liuggio / statsd-php-client

Statsd (Object Oriented) client library for PHP
MIT License
115 stars 32 forks source link

Any plans for next releases? #31

Closed derekchan closed 9 years ago

derekchan commented 10 years ago

Can you make a release to include the new change in master branch? Or any plans on how to proceed with 1.0 / 2.0 branches? I would be happy to help.

liuggio commented 10 years ago

Hi @derekchan For the version 2: I'd like to simplify the API, avoiding the non necessary factory Class and instead provide factory method.

$stats = Statsd::timing(...)

What do you think?

ps: I added the new tag https://github.com/liuggio/statsd-php-client/releases/tag/v1.0.12

sorry for the delay

derekchan commented 10 years ago

Thank you @liuggio for tagging the release!

I agree we can simplify the API. But two questions, based on my own usage:

  1. Will we still be able to plug in alternate Sender interface - as this may be useful in certain set up (e.g. Unit Test environment)
  2. It probably make it harder for Unit Testing code using Statsd client, as you cannot substitute static methods calls with D.I.
liuggio commented 9 years ago

@derekchan tadaa the new version has the a simpler api I think we can close this https://github.com/liuggio/statsd-php-client/releases/tag/v1.0.13