search

liuggio / statsd-php-client

Statsd (Object Oriented) client library for PHP
MIT License
115 stars 32 forks source link

Introduced BC break #41

Closed chmeldax closed 9 years ago

chmeldax commented 9 years ago

Hi,

sadly, StatsdDataFactoryInterface is now not backward compatible, because it introduces new methods to the interface; therefore our custom classes implementing this interface now cannot be used. (the simply do not comply with new interface).

I believe introducing a BC-break should lead to introducing a new major version (according to the semantic versioning). Could you please release a new major version or could you drop setPrefix and setSuffix from the StatsdDataFactoryInterface?

Thanks, Jan

liuggio commented 9 years ago

I agree with you

dav-m85 commented 9 years ago

@chmeldax You are right, I apologize for not foreseeing this (the feature was too cool). I tagged a new v1.0.16 that removes the BC break, and moved the feature in a separate branch feature/prefix_suffix that we will use later for creating a 2.0 release.

Thank you so much for pointing that BC break.

rcrowe commented 9 years ago

We were hit by the same issue & can confirm that this has now fixed it.

chmeldax commented 9 years ago

@dav-m85: Thanks for fixing this issue. Happy to use statsd-php-client again :)