search

liuggio / statsd-php-client

Statsd (Object Oriented) client library for PHP
MIT License
115 stars 32 forks source link

Why has 7fab3b0 been reverted? #51

Closed NinoFloris closed 7 years ago

NinoFloris commented 9 years ago

7fab3b0

Would love to have a prefix feature. My logging classes should not concern themselves with the specific prefix used to send stats. Now I should keep injecting details like this.

liuggio commented 9 years ago

HI @ninoFloris thanks for reporting, @dav-m85 what do you think?

dav-m85 commented 9 years ago

Excellent point.

We had to revert it because it introduced BC break with StatsdDataFactoryInterface. I agree with you this feature is a damn good feature, we should definitely look into reintroducing it.

@NinoFloris Are you willing to submit a PR on this one ?