search

liuggio / statsd-php-client

Statsd (Object Oriented) client library for PHP
MIT License
115 stars 32 forks source link

Missing PHP extensions from composer.json #69

Open reedy opened 10 months ago

reedy commented 10 months ago

This library makes use of both json and sockets functions from PHP, which are commonly part of extensions.

Therefore ext-json and ext-sockets should at least be in suggests (if they are not required for all code paths/are therefore optional), if not in require itself.

https://getcomposer.org/doc/01-basic-usage.md#platform-packages

reedy commented 1 week ago

7a7bea2e2f325c113b249d9a4d1d6aefe52f6274

surdaft commented 2 days ago

Also for those searching, this causes the exception: Uncaught Error: Undefined constant "Liuggio\StatsdClient\Sender\SOL_UDP"

surdaft commented 2 days ago

@reedy is it possible for you to create a branch with all your changes merged in, please?

It seems that @liuggio is not able to maintain the repo at the moment and I definitely appreciate the contributions you have made and would like to make use of them. :)

reedy commented 2 days ago

@reedy is it possible for you to create a branch with all your changes merged in, please?

Based on what version? v1.1.x?

It shouldn't be too difficult to do this yourself, just cherry picking #66 #67 #68 onto a branch (that's what I'm guessing you're wanting?)... And then targetting that with your composer config

The composer.json change is already in that branch, but not master...

surdaft commented 2 days ago

I did find that tag afterwards, was planning to update to use that one. I was thinking that due to your contributions it would be good for other users of the package, as a new home to look at for updates.

I'll take a look, thanks for the links! Apologies if I caused any bother, hope you have a nice evening :)