search

liuliu / ccv

C-based/Cached/Core Computer Vision Library, A Modern Computer Vision Library
http://libccv.org
Other
7.08k stars 1.71k forks source link

Add more configure enable switches #195

Closed jonnor closed 7 years ago

jonnor commented 7 years ago

Especially for dependencies which are GPL

liuliu commented 7 years ago

https://github.com/liuliu/ccv/commit/d50f7bbf0c7c0cdb317d94cc40789df0c4959474

jonnor commented 7 years ago

Thanks for including the changes. In the future will you preserve author information on the commits? This is most easily done by actually doing a git merge, and then fixing any conflicts then. However here it seems I targetted the wrong branch. Then one can do a rebase, which also preserves commit metadata. In the last resort, if re-doing the commit from scratch, one can use git commit --amend --author="Author Name <email@address.com>" to re-add credits.

liuliu commented 7 years ago

Sure. Thanks for note. I normally do squash merge. But will remember about the author name log. The unstable branch is force pushed with commit edited.