search

liumcse / ntuvibe

NTUVibe is a student-run online platform committed to making information at Nanyang Technological University more open and accessible.
https://ntuvibe.com
8 stars 0 forks source link

Refactor Scraper #155

Closed liumcse closed 4 years ago

liumcse commented 4 years ago

Description

Rewrite most code of our Python scraper to encapsulate it into a CLI s.t. it can be invoked to retrieve information such as course content and class schedule.

Usage

  1. Install CLI by pip3 install .
  2. Run command: 
    $ scraper crawl course_content --semester=2019_2
$ scraper crawl class_schedule --semester=2020_1

Checklist

ZaynJarvis commented 4 years ago

Not a good practice to have many "Amend" as commit message. Better include some context about what the commit does. like 

fix(module): change blahblah
or
refactor(module): x y z

then merge into master as small commits rather than a huge squash commit

liumcse commented 4 years ago

Not a good practice to have many "Amend" as commit message. Better include some context about what the commit does. like

fix(module): change blahblah
or
refactor(module): x y z

then merge into master as small commits rather than a huge squash commit

Noted thanks!