liupeirong / MLOpsManufacturing

Demonstrate samples and good engineering practice for operationalizing machine learning solutions.
Other
21 stars 9 forks source link

Removing ci_dependencies.yml from code #66

Closed angie4u closed 3 years ago

angie4u commented 3 years ago

Problem Statement

This sample has two dependencies file(ci_dependencies.yml, dev_dependencies.yml).

However, this two dependencies file is almost same and the presence of both files adds to the confusion.

Solution

Instead of having two similar yml file, decided to use only dev_dependencies.yml)

h2floh commented 3 years ago

Hey @liupeirong , I suggested the change to take the complexity out of the dependency management. While there could be scenarios where we don't need dev libs in the CI environment a CI environment including all dev dependency's probably won't tend to throw missing dependency errors.

What do you think?

liupeirong commented 3 years ago

Dev dependency is a superset of CI dependency, and the difference is small, mostly the debugger. So I think it's a good idea to merge them into one.