search

liushidefeng / protobuf-rpc-pro

Automatically exported from code.google.com/p/protobuf-rpc-pro
0 stars 0 forks source link

Disabling logging #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
We're using your library (with great success) in a backup software we've 
developed (see https://degoo.com). It's used to handle the communication 
between the UI process and the background service. We're primarily using it to 
update the progress of the backup and this is needs to be updated as frequently 
as possible. After some performance optimizations we've done recently we've 
noticed that the logging mechanism in 
com.googlecode.protobuf.pro.duplex.logging.CategoryPerServiceLogger.logCall has 
become a bottleneck. We've disabled the logging of this namespace in our log 
config but there are still operations done that cost us some performance. Any 
chance of adding some configurable if-case around this entire method so that we 
can get rid of the overhead entirely?

Thanks!

Original issue reported on code.google.com by c...@degoo.com on 25 Oct 2014 at 2:04

GoogleCodeExporter commented 9 years ago 
I've introduced a NullLogger which will not log anything. Please use this with 
version 3.2.4.

Original comment by pjklauser@gmail.com on 26 Oct 2014 at 1:09

GoogleCodeExporter commented 9 years ago

Original comment by pjklauser@gmail.com on 26 Oct 2014 at 1:11

GoogleCodeExporter commented 9 years ago 
just released with 3.3

Original comment by pjklauser@gmail.com on 26 Oct 2014 at 4:24