liusida / ComfyUI-B-LoRA

A ComfyUI custom node that loads and applies B-LoRA models.
MIT License
66 stars 5 forks source link

Not all b-lora can take effect #7

Open yatoubusha opened 2 months ago

yatoubusha commented 2 months ago

I test B-LoRA-watercolor [v17], B-LoRA-drawing3[v28],B-LoRA-pen_sketch [v30], only B-LoRA-pen_sketch [v30] can reference the style. i used the workflow you provided. image image image

liusida commented 2 months ago

You are right. I've tried v17, the watercolor, and it is true that the dog is not in the style of watercolor. I think the watercolor style information might not be stored in these layers.

I've compared w/ and w/o the B-LoRA model, and here is the result:

image

liusida commented 2 months ago

image

Since this is the training image, I guess that the B-LoRA model pays too much attention to the white background. (In the previous result, images generated w/ B-LoRA are more likely to have white background.) And maybe there're other explanations/effects as well.

yatoubusha commented 1 month ago

but in huggingface demo, it works, do you try that?

liusida commented 1 month ago

but in huggingface demo, it works, do you try that?

Yes, I have. That demo works.

But I don't know what are the settings and parameters behind that demo. Let me ping the original author @yardenfren1996 to see if we did anything wrong.

Hi @yardenfren1996,

@yatoubusha has found that the demo on huggingface works great but we can't reproduce the result in ComfyUI. Could you show us the settings and parameters used in the huggingface demo? Thanks!

liusida commented 1 month ago

I've dived a bit into ComfyUI's implementation, and I've noticed that ComfyUI often implements its own code for inference.

I'm concerned that ComfyUI might not reproduce the exact results if the original inference code does not use ComfyUI, such as when using PyTorch or diffusers.